Shopify / homebrew-shopify

47 stars 25 forks source link

Cannot tap shopify/shopify: invalid syntax in tap ("def fetch") #233

Closed nolar closed 3 years ago

nolar commented 3 years ago

This is different from #201 — the error is different.

When trying to tap for the first time:

brew tap shopify/shopify

I get numerous warnings and the following error:

………
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/shopify/homebrew-shopify/theme-check.rb
theme-check: Calling `def fetch` in a subclass of `Formulary::FormulaNamespaceeb7b122968da77c64c30f8a803c0134c::ThemeCheck::RubyGemsDownloadStrategy` is disabled! Use `def fetch(timeout: nil, **options)` and output a warning when `options` contains new unhandled options instead.
Please report this issue to the shopify/shopify tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/shopify/homebrew-shopify/theme-check.rb:16

………
Error: Cannot tap shopify/shopify: invalid syntax in tap!

Just in case, the warnings are these (59 of them), but probably not connected to the error:

Warning: Calling `sha256 "digest" => :tag` in a bottle block is deprecated! Use `brew style --fix` on the formula to update the style or use `sha256 tag: "digest"` instead.
Please report this issue to the shopify/shopify tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it: ………

$ brew --version
Homebrew 3.0.11-152-g6359af5
Homebrew/homebrew-core (git revision 1574623ad7; last commit 2021-04-10)
Homebrew/homebrew-cask (git revision 0e863d1706; last commit 2021-04-10)

Everything is updated & upgraded.

MacOS 10.15.7 Catalina, Intel CPU.

reyesvicente commented 3 years ago

Receiving this too when I was installing a cask

➜  ~ brew install --cask <cask_name>
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 4 taps (heroku/brew, shopify/shopify, homebrew/core and homebrew/cask).
==> New Formulae
cadence-workflow   crackpkcs          dua-cli            enkits             epr                kickstart          mx                 net-tools          pcp                systemd
==> Updated Formulae
Updated 849 formulae.
==> New Casks
battery-buddy                                                  katrain                                                        wxmacmolplt
==> Updated Casks
Updated 412 casks.
==> Deleted Casks
battery-guardian                                               beatport-pro                                                   flash-ppapi
Warning: Calling `def fetch` in a subclass of `Formulary::FormulaNamespaceeb7b122968da77c64c30f8a803c0134c::ThemeCheck::RubyGemsDownloadStrategy` is deprecated! Use `def fetch(timeout: nil, **options)` and output a warning when `options` contains new unhandled options instead.
Please report this issue to the shopify/shopify tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/shopify/homebrew-shopify/theme-check.rb:16
andyw8 commented 3 years ago

Similar: https://github.com/Shopify/themekit/issues/926