search

Shopify / hydrogen-demo-store

This template contains a full-featured setup of components, queries and tooling to get started with Hydrogen. It is deployed to https://hydrogen.shop
100 stars 34 forks source link

Update `typographic-base` import #44

Closed frandiox closed 4 months ago

frandiox commented 4 months ago

typographic-base says it has ESM but it really does not. We were manually importing from /index because that's ESM-like but it leads to other issues. It basically imports CJS files, thus masking CJS as ESM.

Changing the import like this makes it easier to optimize the dependency.

shopify[bot] commented 4 months ago
Oxygen deployed a preview of your fd-update-dep branch. Details: Storefront Status Preview link Deployment details Last update (UTC)
Hydrogen Demo Store v2 ✅ Successful (Logs) [Preview deployment]() Inspect deployment May 14, 2024 3:35 AM

Learn more about Hydrogen's GitHub integration.