search

Shopify / hydrogen-demo-store

This template contains a full-featured setup of components, queries and tooling to get started with Hydrogen. It is deployed to https://hydrogen.shop
115 stars 48 forks source link

Edit address url #64

Open jamalsoueidan opened 1 year ago

jamalsoueidan commented 1 year ago

What is the location of your example repository?

0

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

0

What version of Remix are you using?

0

Steps to Reproduce

Edit any address

Expected Behavior

Only id in the url

Actual Behavior

Right now we are encoding 'gid://shopify/MailingAddress/9586653495623?model_n…XsbduYzRGDLmEa1SN9RHx53h1y-B2nb106uljrZ6aErnokDXb'

in the url when clicking edit address in the account page, looks ugly! and it shouldn't be needed, just 9586653495623 should be fine.

blittle commented 1 year ago

Hi @jamalsoueidan, thank you for pointing this out. We'll be improving the demo store implementation in the future, and probably change this. In the mean time, the demo store is just a demo, and you are free to update and change the code however you like!

jamalsoueidan commented 1 year ago

Hi @jamalsoueidan, thank you for pointing this out. We'll be improving the demo store implementation in the future, and probably fix this. In the mean time, the demo store is just a demo, and you are free to update and change the code however you like!

Demo or not, good patterns should used :)