Closed frandiox closed 1 month ago
We detected some changes in packages/*/package.json
or packages/*/src
, and there are no updates in the .changeset
.
If the changes are user-facing and should cause a version bump, run npm run changeset add
to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.
Related to #1992
A bit of a tricky issue:
--customer-account-push__unstable
and have noPUBLIC_STORE_DOMAIN
in.env
, it will think you're using mock.shop and skip the tunnel. This would be correct if we had all the variables at this point, but this is only considering local variables. The domain might be injected later from remote/admin variables.PUBLIC_STORE_DOMAIN=""
in.env
overwrites remote values and uses mock.shop. We still need to disable tunnel in this case.To 🎩 , ensure
--customer-account-push__unstable
has the expected behavior when:PUBLIC_STORE_DOMAIN
is set to a real domain (e.g.hydrogen-preview.myshopify.com
) in.env
=> starts the tunnel + no warning.PUBLIC_STORE_DOMAIN
is undefined in.env
=> starts the tunnel + no warning.PUBLIC_STORE_DOMAIN
is set tomock.shop
in.env
=> skips the tunnel + info banner in terminal about mock.shop.PUBLIC_STORE_DOMAIN
is empty string in.env
=> skips the tunnel + info banner in terminal about mock.shop.