Fix `storefrontRedirect` to strip trailing slashes in querying for redirects - Githubissues

Shopify / hydrogen

Hydrogen lets you build faster headless storefronts in less time, on Shopify.

https://hydrogen.shop

MIT License

1.24k stars 246 forks source link

Fix `storefrontRedirect` to strip trailing slashes in querying for redirects #2110

Closed blittle closed 4 weeks ago

blittle commented 1 month ago

WHY are these changes introduced?

The admin doesn't allow you to save a redirect with a trailing slash, so it should be safe to always strip it

Fixes #2090

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

[X] I've read the Contributing Guidelines
[X] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[X] I've added a changeset if this PR contains user-facing or noteworthy changes
[X] I've added tests to cover my changes
[] I've added or updated the documentation

shopify[bot] commented 1 month ago

Oxygen deployed a preview of your `bl-fix-redirect-slashes` branch. Details:	Storefront	Status	Preview link	Deployment details	Last update (UTC)
vite	✅ Successful (Logs)	Preview deployment	Inspect deployment	May 14, 2024 5:10 PM
custom-cart-method	✅ Successful (Logs)	Preview deployment	Inspect deployment	May 14, 2024 5:10 PM
optimistic-cart-ui	✅ Successful (Logs)	Preview deployment	Inspect deployment	May 14, 2024 5:10 PM
Skeleton (skeleton.hydrogen.shop)	✅ Successful (Logs)	Preview deployment	Inspect deployment	May 14, 2024 5:10 PM
subscriptions	✅ Successful (Logs)	Preview deployment	Inspect deployment	May 14, 2024 5:11 PM
third-party-queries-caching	✅ Successful (Logs)	Preview deployment	Inspect deployment	May 14, 2024 5:11 PM

Learn more about Hydrogen's GitHub integration.