Shopify / hydrogen

Hydrogen lets you build faster headless storefronts in less time, on Shopify.
https://hydrogen.shop
MIT License
1.21k stars 243 forks source link

Don't filter product options with only one value in the VariantSelector #2113

Open blittle opened 2 weeks ago

blittle commented 2 weeks ago

WHY are these changes introduced?

We are in the process of simplifying and improving the components offered by Hydrogen. As a part of that, it's been requested that the VariantSelector component be changed to not filter out options that have only one value. This is a breaking change.

See the changeset for an example on how to migrate.

Fixes #1198

HOW to test your changes?

  1. Make sure that the skeleton template does not display product options for a product that does not have more than one value. For example: /products/shopify-wax

Post-merge steps

Checklist

shopify[bot] commented 2 weeks ago
Oxygen deployed a preview of your bl-variant-selector-filter branch. Details: Storefront Status Preview link Deployment details Last update (UTC)
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 8:10 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 8:10 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 8:10 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 8:10 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 8:11 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 8:10 PM

Learn more about Hydrogen's GitHub integration.

blittle commented 2 weeks ago

Okay, I'll hold off merging.