Shopify / hydrogen

Hydrogen lets you build faster headless storefronts in less time, on Shopify.
https://hydrogen.shop
MIT License
1.45k stars 277 forks source link

ESLint v8.x is end of life #2606

Open tomtuv opened 1 month ago

tomtuv commented 1 month ago

What is the location of your example repository?

No response

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

2024.7.9

What version of Remix are you using?

2.10.1

Steps to Reproduce

  1. Create a new Hydrogen project
  2. Install the dependencies
  3. Check ESLint version

Expected Behavior

The Skeleton template should use ESLint 9.

Actual Behavior

The Skeleton template is using ESLint 8.x which is end of life since October 5, 2024.

https://eslint.org/blog/2024/09/eslint-v8-eol-version-support/

wizardlyhel commented 1 month ago

I looked into upgrading eslint on Hydrogen. Currently block by other eslint plugins not supporting eslint 9.x:

So far I have figure out the following hasn't support eslint 9.x

Biggest one being @remix-run/eslint-config pinning the parser @typescript-eslint/parser at 5.x where the latest is at 8.x which supports eslint 9.x.

We can nudge Remix team on updating @remix-run/eslint-config Also need to fix or kill eslint-plugin-hydrogen

tomtuv commented 1 month ago

@wizardlyhel Thank you for the response!

I think @remix-run/eslint-config is deprecated:

wizardlyhel commented 1 month ago

Yea - just talked with the Remix team. We'll also move that dependency