search

Shopify / hydrogen

Hydrogen lets you build faster headless storefronts in less time, on Shopify.
https://hydrogen.shop
MIT License
1.44k stars 273 forks source link

Issue With New Accounts Login #2641

Open dcodrin opened 3 days ago

dcodrin commented 3 days ago

What is the location of your example repository?

https://github.com/Shopify/hydrogen-demo-store

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

^2024.10.0

What version of Remix are you using?

^2.13.1

Steps to Reproduce

  1. Ensure you are logged out
  2. Navigate to https://hydrogen.shop/products/the-liquid?Size=154cm&Color=Syntax
  3. Verify that you can open the cart and can add to cart any of the variants from Step 2
  4. Click on the header icon to log in
  5. Do not enter email, click the back button to navigate back to same page as step 2 (https://hydrogen.shop/products/the-liquid?Size=154cm&Color=Syntax)
  6. Try adding something to cart or removing from cart.
  7. You will be redirected back to the login page
  8. Click back button again. You will now be stuck in a broken experience unable to undertake any action unless you refresh the page.

Expected Behavior

Users should be able to continue adding to cart without facing any issues like the initial forced redirect to login or the completely broken experience.

Actual Behavior

The users are stuck in a broken experience.

Please note that we noticed a drop in conversion rates following the implementation of the new accounts login and we were unable to pinpoint the issue until now. We believe that this is especially bad for users of instagram where they are used to shopping via the built-in browser where there's no refresh button (if they scrolled down and the drawer is stuck open there's no way to scroll back up to show the refresh button) and for those stuck with the open drawer there's nothing they can do.

Hopefully this could be addressed before Black Friday.

https://github.com/user-attachments/assets/36c58dc1-dab4-4352-8631-405fb0611f0f

dcodrin commented 3 days ago

For us the fix was to replace the Link component with an a tag.