Shopify / javascript-utilities

A set of utilities for JavaScript and TypeScript projects at Shopify.
MIT License
45 stars 9 forks source link

Initialize repo :tada: #1

Closed ismail-syed closed 7 years ago

ismail-syed commented 7 years ago

Pulled out ./packages/@shopify/utilities/ from neutron into it's own repo.

ismail-syed commented 7 years ago

@GoodForOneFare Going to make this public right after this initial PR gets in.

ismail-syed commented 7 years ago

@lemonmade @GoodForOneFare

PR comments have been addressed. Below is what the published package will look like:

╭─ismailsyed@OTT-IsmailSyed  ~/src/github.com/Shopify/javascript-utilities  ‹initiaize*›
╰─$ tar -tf shopify-javascript-utilities-0.0.1.tgz
package/package.json
package/README.md
package/lib/url.js
package/lib/other.js
package/lib/dates.js
package/lib/geometry.js
package/lib/dom.js
package/lib/feature-detect.js
package/lib/events.js
package/lib/autobind.js
package/lib/fastdom.js
package/lib/fastdom.d.ts
package/lib/feature-detect.d.ts
package/lib/events.d.ts
package/lib/geometry.d.ts
package/lib/dom.d.ts
package/lib/other.d.ts
package/lib/dates.d.ts
package/lib/url.d.ts
package/lib/autobind.d.ts
package/src/autobind.ts
package/src/dates.ts
package/src/dom.ts
package/src/events.ts
package/src/fastdom.ts
package/src/feature-detect.ts
package/src/geometry.ts
package/src/other.ts
package/src/url.ts
package/yarn.lock

I just did a small test to see if the paths resolve properly, by installing this locally to neutron. Seems to be working.

With this new module our imports will look as follows

Before:

import {getPath} from '@shopify/utilities/url';

After:

import {getPath} from '@shopify/javascript-utilities/lib/url';

If we output to the root instead of ./lib we could minimize the work required to pull this into neutron.

lemonmade commented 7 years ago

Ooo yeah output to root, that would be much nicer. After that this LGTM 👍