search

Shopify / javascript-utilities

A set of utilities for JavaScript and TypeScript projects at Shopify.
MIT License
45 stars 9 forks source link

Prevent false positives for future dates in `isLessThan*` functions #52

Closed rexmac closed 5 years ago

rexmac commented 5 years ago

Fix isLessThan* functions to return false for dates in the future.

Future dates cause the time diff to be negative which always passes the isLessThan* conditions.

rexmac commented 5 years ago

We should add a changelog entry.

🤦‍♂ Doh! I always forget those! Will add.