Shopify / javascript

The home for all things JavaScript at Shopify.
MIT License
251 stars 38 forks source link

Fix invalid RegExp definition in `RteAsset` #119

Closed GoodForOneFare closed 8 years ago

GoodForOneFare commented 8 years ago

Raise: Fix invalid RegExp definition in RteAsset

rte_asset.coffee:

class Shopify.RteAsset

  shopifyRegex: new RegExp(/files\/\d\/\d{4}\/\d{4}\/(files|products|assets)/)

becomes:

rte-asset.js:

export default class RteAsset {
  shopifyRegex = new shopifyRegex(/files\/\d\/\d{4}\/\d{4}\/(files|products|assets)/);
GoodForOneFare commented 8 years ago

Assuming this is a decaf problem.

lemonmade commented 8 years ago

oh decaf.

GoodForOneFare commented 8 years ago

Hold up. This is one of the issues that'd be fixed a merge of mainline's fixes.

lemonmade commented 8 years ago

👍

GoodForOneFare commented 8 years ago

Fixed by mainline decaf merge.