search

Shopify / javascript

The home for all things JavaScript at Shopify.
MIT License
251 stars 38 forks source link

Decaf should handle `Shopify.Mixin` calls #161

Closed GoodForOneFare closed 8 years ago

GoodForOneFare commented 8 years ago

It looks like most of decaf's remaining problems with shopify/shopify's classes is from Shopify.Mixin calls like:

class Shopify.AdminEmbeddedAppHost.DateRangeControl

  Shopify.Mixin(
    @prototype
    Shopify.DateHandler
  )

  # SNIP regular class code.

I think this can be rewritten to a JS equivalent of:

class Shopify.AdminEmbeddedAppHost.DateRangeControl
  // SNIP regular class code.
}

Shopify.Mixin(Shopify.AdminEmbeddedAppHost.DateRangeControl.prototype, Shopify.DateHandler);
GoodForOneFare commented 8 years ago

As part of this, figure out what other private class calls are being made, and fix/raise issues along the way.

GoodForOneFare commented 8 years ago

Fixed by https://github.com/Shopify/decaf/pull/12. This addresses all private class calls.