search

Shopify / javascript

The home for all things JavaScript at Shopify.
MIT License
251 stars 38 forks source link

Warn about `for...in`->`for...Object.entries`-style mismatch & null guards #243

Closed GoodForOneFare closed 7 years ago

GoodForOneFare commented 7 years ago

Adds some really verbose warnings about for loop conversions. I think the wording needs a lot of work.

Sample output: shopify zsh 2016-11-24 11-16-27

Please review: @lemonmade, @TylerHorth

TylerHorth commented 7 years ago

I think It's alright to be verbose in this instance. Someone not familiar with modern javascript is going to have a hard time figuring out what they're supposed to do otherwise.

lemonmade commented 7 years ago

As Tyler said, I'm fine with verbosity given the complexity of the things you are warning about.