search

Shopify / javascript

The home for all things JavaScript at Shopify.
MIT License
251 stars 38 forks source link

Esify should not delete sprocket directives #70

Closed andyfangaf closed 8 years ago

andyfangaf commented 8 years ago

Manifest files are being ignored by Esify.

Steps to reproduce:

  1. esify app/assets/javascripts/admin/admin_vendors.coffee
  2. See app/assets/javascripts/admin/admin_vendors.js

admin_vendors.js is empty because admin_vendors.coffee is commented. Decaf treats it as an empty file and thus isn't compiling it.

Main culprits

cc @lemonmade

lemonmade commented 8 years ago

Good catch. I've manually converted these files in this PR: https://github.com/Shopify/shopify/pull/71460, so I think that should resolve this issue.

bouk commented 8 years ago

@fandy this is unfortunately a limitation of decafjs https://github.com/juliankrispel/decaf/issues/1