Shopify / koa-shopify-auth

DEPRECATED Middleware to authenticate a Koa application with Shopify
MIT License
80 stars 63 forks source link

API Deprecation Notice from metafields API call #138

Closed kohiki-dev closed 1 year ago

kohiki-dev commented 2 years ago

Issue summary

Hello! I am getting the following warning in my logs even though my app is not using the deprecated API "metafields.valueType". I'm not sure where to find the code that causes this warning.

log:

API Deprecation Notice: {
 message: 'https://shopify.dev/changelog/online-store-2-0-new-metafields-type-system-and-dynamic-sources',
 path: 'https://shop-name.myshopify.com/admin/api/2021-10/metafields.json?limit=1'
}

Expected behavior

My app is not using the deprecated API, so we shouldn't see this notification in the log.

Actual behavior

Notifications about deprecated APIs will be displayed in the log.

log:

API Deprecation Notice: {
 message: 'https://shopify.dev/changelog/online-store-2-0-new-metafields-type-system-and-dynamic-sources',
 path: 'https://shop-name.myshopify.com/admin/api/2021-10/metafields.json?limit=1'
}

I clicked on "path" and got the following screen. I see an object with the key "metafields" and an empty array for the value.

Image from Gyazo

Additional Information

aldoalprak commented 2 years ago

This issue has been more than 6 months, but there is no news from the contributor. You can refer to this thread #118

TheSecurityDev commented 2 years ago

I've just created a simpler version of this library (that fixes this and other issues), which you can find at https://www.npmjs.com/package/simple-koa-shopify-auth

agustinsacco commented 2 years ago

This sounds so backwards. I am getting denied my app submission because API is outdated. I cannot upgrade the API usage without a new version of this package which is supported and maintained by Shopify.

Are we to understand that we all need to develop new libraries and support them ourselves?

github-actions[bot] commented 1 year ago

Note that this repo is no longer maintained and this issue will not be reviewed. Prefer the official JavaScript API library. If you still want to use Koa, see simple-koa-shopify-auth for a potential community solution.