Shopify / koa-shopify-auth

DEPRECATED Middleware to authenticate a Koa application with Shopify
MIT License
80 stars 63 forks source link

New API version on Shopify, @shopify/koa-shopify-auth ApiVersion is outdated. #139

Closed lukamusashvili closed 1 year ago

lukamusashvili commented 2 years ago

Hi guys, I need to use Shopify's new API version. Could u pls update the library? 1

agustinsacco commented 2 years ago

I am also stuck here. I have relayed the information to shopify since I am submitting a new app and they keep telling me to update thte api version but this package has not been updated.

Since this is the recommended package used in the boilerplate node app I want to continue using it instead of forking and upgrading myself (which will put me at a disadvantage in the future).

Not sure how to proceed since it doesnt look like this package is getting much support from Shopify tech team.

aldoalprak commented 2 years ago

Hi @lukamusashvili , I don't think it's because of this package, maybe you're problem is on "shopify-api" package. If you want to use the latest version (2022-01), you can directly hardcode the version. Example below:

Shopify.Context.initialize({ API_KEY: SHOPIFY_API_KEY, API_SECRET_KEY: SHOPIFY_API_SECRET_KEY, SCOPES: SCOPES, HOST_NAME: APP_URL.replace(/https:\/\//, ""), API_VERSION: "2022-01", IS_EMBEDDED_APP: true, SESSION_STORAGE: new Shopify.Session.CustomSessionStorage( sessionStorage.storeCallback, sessionStorage.loadCallback, sessionStorage.deleteCallback, ), });

lukamusashvili commented 2 years ago

Hi @lukamusashvili , I don't think it's because of this package, maybe you're problem is on "shopify-api" package. If you want to use the latest version (2022-01), you can directly hardcode the version. Example below:

Shopify.Context.initialize({ API_KEY: SHOPIFY_API_KEY, API_SECRET_KEY: SHOPIFY_API_SECRET_KEY, SCOPES: SCOPES, HOST_NAME: APP_URL.replace(/https:\/\//, ""), API_VERSION: "2022-01", IS_EMBEDDED_APP: true, SESSION_STORAGE: new Shopify.Session.CustomSessionStorage( sessionStorage.storeCallback, sessionStorage.loadCallback, sessionStorage.deleteCallback, ), });

I tried updating the library about 3 month ago, I couldn't even authorize in Shopify after that. Made some researches and found out that I cannot touch [shopify-api] manually, it has to be installed by [@shopify/koa-shopify-auth] library, which uses old version of [shopify-api]. this is my issue actually, the problem can be solved by supporting newer [shopify-api] version

github-actions[bot] commented 1 year ago

Note that this repo is no longer maintained and this issue will not be reviewed. Prefer the official JavaScript API library. If you still want to use Koa, see simple-koa-shopify-auth for a potential community solution.