search

Shopify / koa-shopify-auth

DEPRECATED Middleware to authenticate a Koa application with Shopify
MIT License
80 stars 63 forks source link

Redirect to cookie grant page using App Bridge #148

Closed paulomarg closed 2 years ago

paulomarg commented 2 years ago

WHY are these changes introduced?

EASDK is deprecated, and we're currently still relying on it for one of the top-level redirects required to handle ITP for Safari. We need to migrate away from doing that.

WHAT is this pull request doing?

Replacing the current EASDK-based call with an App Bridge (v1 for consistency with other usages in this package) Redirect action.

I verified that the redirect works with App Bridge on Safari.

Type of change

caution-tape-bot[bot] commented 2 years ago

:wave: It looks like you're updating JavaScript packages that are known to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file, you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their default context values. Multiple versions of such packages will yield multiple global instances, resulting in oblique runtime errors.