Shopify / koa-shopify-auth

DEPRECATED Middleware to authenticate a Koa application with Shopify
MIT License
80 stars 64 forks source link

Navigation to enable_cookies page when using session token #93

Closed assaflei closed 1 year ago

assaflei commented 3 years ago

Issue summary

I was using the node react guide to create a new app.

During authentication I noticed that the flow includes navigation to the enable_cookies page While quickly leaving the page I think that seeing it during the process is not an expected behavior taking into account that cookies are not being used anymore

Expected behavior

The login flow should not include enable_cookies page

Actual behavior

The login flow includes enable_cookies page See below network tab from browser

image

Steps to reproduce the problem

Follow the guide and execute the app. Trace the navigated pages

Reduced test case


Checklist

avocadoslab commented 3 years ago

This is expected behavior as per https://github.com/Shopify/koa-shopify-auth/issues/81#issuecomment-816656683

github-actions[bot] commented 1 year ago

Note that this repo is no longer maintained and this issue will not be reviewed. Prefer the official JavaScript API library. If you still want to use Koa, see simple-koa-shopify-auth for a potential community solution.