Refactor: Utility function to check AccessMode is Online/Offline - Githubissues

Shopify / koa-shopify-auth

DEPRECATED Middleware to authenticate a Koa application with Shopify

MIT License

80 stars 63 forks source link

Refactor: Utility function to check AccessMode is Online/Offline #95

Closed akhilmhdh closed 2 years ago

akhilmhdh commented 3 years ago

WHY are these changes introduced?

Fixes #60

Hardcoded checks whether accessMode is online that can cause unnecessary bugs.

WHAT is this pull request doing?

Refactored accessMode checks to a utility function shared by auth module and verify-request module.
Moved utilities functions shared by both into another folder called utilities
Added test for utilities folder.

Type of change

[x] Patch: Bug (non-breaking change which fixes an issue)
[ ] Minor: New feature (non-breaking change which adds functionality)
[ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above
[x] I have added/updated tests for this change