Fix statefulset pod selector

Shopify / krane

A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result

MIT License

1.38k stars 114 forks source link

Fix statefulset pod selector #954

Closed JamesOwenHall closed 6 months ago

JamesOwenHall commented 6 months ago

What are you trying to accomplish with this PR? When deploying a StatefulSet, deploys could sporadically be marked failed due to Krane monitoring the health of the current revision's pods, not the updated revision. This PR updates the logic to monitor the updated revision.

How is this accomplished? StatefulSet#parent_of_pod? is the method that filters pods. I've updated it to select pods matching .status.updateRevision.

What could go wrong? ...

JamesOwenHall commented 6 months ago

🎩 'ed and seems to have fixed the issue.