refactors sarif test - Githubissues

Shopify / kubeaudit

kubeaudit helps you audit your Kubernetes clusters against common security controls

MIT License

1.89k stars 183 forks source link

refactors sarif test #469

Closed dani-santos-code closed 2 years ago

dani-santos-code commented 2 years ago

reference: https://github.com/Shopify/kubeaudit/pull/453/files#r938176410

this PR:

exports the results field in the Report struct:

type Report struct {
    Results []Result
}

renames results function to GetResults:
```
func (r *Report) GetResults() []Result
```

dani-santos-code commented 2 years ago

great idea! renaming Results to GetResults was an unnecessary breaking change when we can just export workloadResult. Also liked the wrapper around Results, with NewReport. Thanks for pairing on this! 🙏