robinelfrink commented 9 months ago

Description

Make gorelease build sstatic binaries, instead of dynamically linked. This ensures the binaries are useable on (almost) any version and variations of operating systems the binaries are built for, and also makes sure the docker container has a static binary.

Fixes #579

Type of change

[x] Bug fix :bug:

Checklist:

[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] The test coverage did not decrease
[ ] I have signed the appropriate Contributor License Agreement

I will not sign the CLA, as it wants my home address, and I think that is completely irrelevant.

I hereby grant Shopify the right to simply copy the line I added to .goreleaser.yml.

dani-santos-code commented 8 months ago

hi, @robinelfrink ! thank you for your contribution. Can you sign the CLA here? https://cla.shopify.com/

robinelfrink commented 8 months ago

Hi @dani-santos-code,

hi, @robinelfrink ! thank you for your contribution. Can you sign the CLA here? https://cla.shopify.com/

No, I cannot. The form wants my home address. I don't see how that is relevant.

BoBeR182 commented 4 months ago

I signed the CLA and submitted the patch.

Shopify / kubeaudit

build static binaries (#579) #580

Description

Type of change

Checklist:

592