Shopify / lighthouse-ci-action

MIT License
101 stars 50 forks source link

SHOP_STORE: unbound variable #11

Closed dominikx96 closed 3 years ago

dominikx96 commented 3 years ago

During action start the action fails.

Output:

==============================
9: Configuring shopify CLI
10: /entrypoint.sh: line 98: SHOP_STORE: unbound variable

Also, instruction from: lighthouse-ci seems to be out of date).

on: [push] - doesn't work

on: push - correct format from: treosh/lighthouse-ci-action

colinloretz commented 3 years ago

@dominikx96 did you find a workaround to this? I have my github secrets enabled but running into this same action failure.

Thanks!

simon-bd commented 1 year ago

@colinloretz did you find a solution?

damiankrzyz commented 1 year ago

@simon-bd @colinloretz try adding Repository secrets Screenshot 2023-03-14 at 21 47 19

charlespwd commented 1 year ago
        uses: shopify/lighthouse-ci-action@v1
        with:
          store: ${{ secrets.SHOP_STORE }}

This require the SHOP_STORE secret to be set, as per screenshot above.

michaelburtonray commented 7 months ago
        uses: shopify/lighthouse-ci-action@v1
        with:
          store: ${{ secrets.SHOP_STORE }}

This require the SHOP_STORE secret to be set, as per screenshot above.

is SHOP_STORE examplestore or examplestore.myshopify.com ?

charlespwd commented 7 months ago

@michaelburtonray it would be the full examplestore.myshopify.com