Shopify / lighthouse-ci-action

MIT License
100 stars 50 forks source link

Update query string to include theme id for development theme preview #36

Closed muriloshimizu closed 2 years ago

muriloshimizu commented 2 years ago

Fixes #18. Also fixes an issue with the Lighthouse CI returning only 1 report (of the password page itself).

Setup:

The problem:

How this PR fixes the problem: One of the main things I noticed, is that $host is the main Shopify store url, which ignores the new development store created by this action. That $host is being used on a few places where the development preview url is needed instead.

Maybe it was possible to use $preview_url instead of $host, but at the same time 1) the preview_url path differs for the index, products and collections; and 2) we need the $query_string.

Steps to fix the problem:

Other considerations:

Note: this is my first ever PR for a public repo, hooray!

muriloshimizu commented 2 years ago

Just signed the CLA, not sure how to run the check again...