Open cerenervia opened 2 years ago
I believe this is normal, because we need to somehow set the theme ID with the changes from the repo.
We can achieve that with preview_theme_id
parameter that then redirects to preview of the theme from the repo.
Running into this now, @vfonic isn't the problem because of the preview_theme_id
parameter? Or are you suggesting we can prevent a redirect by manually including that parameter in the theme url?
When you say "theme url" do you mean "store url"?
In order to use the theme with your latest changes so that you can test it with Lighthouse, you need to:
Upload the theme to the store
Instruct the browser to use that theme
is done automatically
is done via preview_theme_id
parameter in the link to the store page. This is stored in session or cookie and that's how this works.
I don't think there's a way to prevent the page redirect because we'd need a very low level access to achieve that.
Not sure how those first 3 steps help, the lighthouse ci action automatically generates this theme id and uses it when requesting to run.
I don't think there's a way to prevent the page redirect
So we should all just expect less than helpful and erroneous performance scores?
No idea. I'm not working for Shopify. I'm just trying to be helpful.
Lighthouse seems to make redirection for each tested URL. Is it normal? Are results altered by this waring?
Screnshot attached:![image](https://user-images.githubusercontent.com/101405717/162949828-783bf307-83fd-494d-b46b-1783297ca5b5.png)