search

Shopify / lighthouse-ci-action

MIT License
100 stars 50 forks source link

Website documentation is outdated #44

Closed vfonic closed 1 year ago

vfonic commented 2 years ago

Hi!

The documentation on the Shopify website is outdated, even incorrect in some places: https://shopify.dev/themes/tools/lighthouse-ci

For example: https://shopify.dev/themes/tools/lighthouse-ci#1-add-your-custom-app-access-token-to-github

SHOP_PASSWORD - The password for your development store. If you don't provide this value, then Lighthouse is redirected to the password page and will not accurately test your theme's performance.

The runs-on: self-hosted also seems like an odd choice. The documentation in README uses ubuntu-latest instead.

charlespwd commented 2 years ago

I pinged the docs folks :pray: Thanks for flagging.

shainaraskas commented 1 year ago

docs updated