Shopify / lighthouse-ci-action

MIT License
100 stars 50 forks source link

SHOP_APP_PASSWORD: unbound variable #45

Closed driespieters closed 2 years ago

driespieters commented 2 years ago

I keep on getting this error:

/entrypoint.sh: line 148: SHOP_APP_PASSWORD: unbound variable

For:

on: [push]
jobs:
  lhci:
    name: Lighthouse
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Lighthouse
        uses: shopify/lighthouse-ci-action@v1
        with:
          access_token: ${{ secrets.SHOP_APP_ID }}
          store: ${{ secrets.SHOP_STORE }}
          lhci_github_app_token: ${{ secrets.LHCI_GITHUB_TOKEN }}

I'm using the access_token for auth.

charlespwd commented 2 years ago
      access_token: ${{ secrets.SHOP_APP_ID }}

Shouldn't this be SHOP_ACCESS_TOKEN? It would be because the access_token variable is empty.

So my guess is that the workflow references an undefined secret variable.

driespieters commented 2 years ago

That did it! Can't believe I overlooked that. (Although I did copy/paste it from somewhere) Thanks!