Update `shopify/lighthouse-ci-action` to rely on Shopify CLI 3.x + Theme Access app

Shopify / lighthouse-ci-action

MIT License

99 stars 50 forks source link

Update `shopify/lighthouse-ci-action` to rely on Shopify CLI 3.x + Theme Access app #51

Open karreiro opened 1 year ago

karreiro commented 1 year ago

Currently, the Lighthouse CI GH action relies on Shopify CLI 2.x: https://github.com/Shopify/lighthouse-ci-action/blob/main/entrypoint.sh#L130

This issues aims to update it to rely on the Theme Access app and Shopify CLI 3.x.

⚠️ This issue impacts documentation: https://shopify.dev/themes/tools/lighthouse-ci

knjshimi commented 1 year ago

Hi @karreiro, just checking if this is still on Shopify plans for the near future. Thank you!

karreiro commented 1 year ago

Hi, @kenji-twp, thanks for reaching out. Yes, this is definitely on our plans, still we don't have a specific timeframe at the moment.

knjshimi commented 1 year ago

Thanks @karreiro! Just to confirm, is the current version of the shopify lighthouse CI action working despite of it using Shopify CLI 2? If so, will it continue to work when v2 sunsets?

satish-bjss commented 9 months ago

Why do we hardcode ruby version rather install within Shopify CLI as an internal dependency OR allow to apply

-use: ruby/setup-ruby@v1 with: ruby-version: x.x bundler: 'latest'