Adds an optional param for pull_theme which, if provided, will pull the JSON templates and settings values for a specified theme
Update Dockerfile to reinstall shopify-cli gem. The image has an older version of shopify-cli (2.0.1) that is missing key theme pull options
Why I'm adding it
On the Theme Design team we need to track lighthouse scores for realistic storefronts, e.g. those with image heroes and many sections. We also may need to test different configurations (various combinations of sections, menu styles, etc.) However, the lighthouse action currently only tests against the default settings of a theme.
Approach taken
Uninstalls the existing shopify-cli gem and reinstalls the latest version. I found this was preferable to rebuilding and re-hosting the docker image with a new shopify-cli install but I'm open to it if there's someone available to assist.
Checks for a pull_theme option passed to the github action. This should be a theme name or theme ID, same as shopify theme pull --theme.
If pull_theme exists it triggers an extra step in the script to pull the theme settings.
Testing instructions
Add a CI job to a theme pointing to the latest SHA in this PR:
Summary
pull_theme
which, if provided, will pull the JSON templates and settings values for a specified themeshopify-cli
gem. The image has an older version of shopify-cli (2.0.1) that is missing keytheme pull
optionsWhy I'm adding it
On the Theme Design team we need to track lighthouse scores for realistic storefronts, e.g. those with image heroes and many sections. We also may need to test different configurations (various combinations of sections, menu styles, etc.) However, the lighthouse action currently only tests against the default settings of a theme.
Approach taken
shopify-cli
gem and reinstalls the latest version. I found this was preferable to rebuilding and re-hosting the docker image with a newshopify-cli
install but I'm open to it if there's someone available to assist.pull_theme
option passed to the github action. This should be a theme name or theme ID, same asshopify theme pull --theme
.pull_theme
exists it triggers an extra step in the script to pull the theme settings.Testing instructions
Add a CI job to a theme pointing to the latest SHA in this PR:
Run the lighthouse-ci action, e.g. by posting a new PR.
Check the lighthouse reports generated by the action. Confirm that the settings from the theme specified were pulled successfully.