search

Shopify / lighthouse-ci-action

MIT License
100 stars 50 forks source link

SHOP_APP_PASSWORD: unbound variable #65

Open rahulpatidar0191 opened 1 year ago

rahulpatidar0191 commented 1 year ago

Similar to https://github.com/Shopify/lighthouse-ci-action/issues/45 but we are passing access_token

This workflow seems to work fine with no errors 

    steps:
      - uses: actions/checkout@v3

      - name: Lighthouse CI
        uses: shopify/lighthouse-ci-action@v1
        with:
          store: ${{ secrets.STORE_NAME}}
          access_token: ${{ secrets.SHOP_ACCESS_TOKEN }}
          password: ${{ secrets.THEME_PASSWORD }}
          lhci_github_token: ${{ secrets.GITHUB_TOKEN }}
          pull_theme: <theme_name>

But when we pass product_handle and collection_handle we get SHOP_APP_PASSWORD: unbound variable error

      - name: Lighthouse CI
        uses: shopify/lighthouse-ci-action@v1
        with:
          store: ${{ secrets.STORE_NAME}}
          access_token: ${{ secrets.SHOP_ACCESS_TOKEN }}
          password: ${{ secrets.THEME_PASSWORD }}
          lhci_github_token: ${{ secrets.GITHUB_TOKEN }}
          pull_theme: <theme_name>
          collection_handle: "<collection_handle>"
          product_handle: "<product_handle>"