search

Shopify / lighthouse-ci-action

MIT License
100 stars 50 forks source link

fix: missing theme_root on theme pull #66

Closed charlienaud closed 1 year ago

charlienaud commented 1 year ago

pull_theme feature added in #57 is not using the theme_root config.

This causing the action to be stuck indefinitely after executing the shopify theme pull command if we use both pull_theme and a custom path for theme_root because the CLI is not able to find the theme and is waiting for user input.

charlienaud commented 1 year ago

I have signed the CLA!

charlespwd commented 1 year ago

Thank you for your contribution :D, it's fixed in the latest v1, v1.1 and v1.1.2 tags