Shopify / liquid-c

Liquid performance extension in C.
MIT License
119 stars 24 forks source link

Renable assert in development after ruby intentionally disabled it #194

Closed dylanahsmith closed 1 year ago

dylanahsmith commented 1 year ago

Closes #193

I found https://bugs.ruby-lang.org/issues/18777 which specifically reported this issue upstream, where it was indeed closed as being intentional behaviour. However, the reporter of the issue did post a workaround of wrapping the include to ruby.h to #undef NDEBUG if it wasn't set before the include. That seems like a more targeted fix for the problem than #193, although still an unfortunate hack.