don't reset Liquid tag's whitespace control from comment tag

Shopify / liquid

Liquid markup language. Safe, customer facing template language for flexible web apps.

https://shopify.github.io/liquid/

MIT License

11.05k stars 1.38k forks source link

don't reset Liquid tag's whitespace control from comment tag #1773

Closed ggmichaelgo closed 9 months ago

ggmichaelgo commented 9 months ago

https://github.com/Shopify/liquid/pull/1764 introduced a bug that a comment tag inside a liquid tag overrides the liquid tag's whitespace control.

A Liquid template like this would expected to output Hello!World! but since the endcomment tag delimiter disables the whitespace control, it outputs Hello!\nWorld!

Hello!
{%- liquid
  comment
    this is inside a liquid tag
  endcomment
-%}
World!