search

Shopify / liquid

Liquid markup language. Safe, customer facing template language for flexible web apps.
https://shopify.github.io/liquid/
MIT License
11.05k stars 1.38k forks source link

add new TemplateEncodingError #1776

Closed ggmichaelgo closed 8 months ago

ggmichaelgo commented 8 months ago

What are you trying to solve?

Instead of raising the SyntaxError when the template has an invalid UTF-8 sequence, raise a specific TemplateEncodingError.

zachmccormick commented 6 months ago

Does this need to be updated in the liquid-c gem? I am getting failures for https://github.com/Shopify/liquid-c/blob/main/test/unit/variable_test.rb#L289