Ignore URI::RFC3986_PARSER.escape deprecation warning

Shopify / maintenance_tasks

A Rails engine for queueing and managing data migrations.

MIT License

1.04k stars 76 forks source link

Ignore URI::RFC3986_PARSER.escape deprecation warning #1115

Closed adrianna-chang-shopify closed 1 week ago

adrianna-chang-shopify commented 1 week ago

uri switched the default parser from RFC2396 to RFC3986. The new parser emits a deprecation warning on a few methods and delegates them to RFC2396. See https://github.com/ruby/uri/pull/114.

The selenium-webdriver gem calls URI::RFC3986_PARSER.escape, which is now deprecated. Until this is fixed in selenium-webdriver, ignore the warning.

Fixes failing weekly CI build: https://github.com/Shopify/maintenance_tasks/actions/runs/11769507051/job/32815543032

adrianna-chang-shopify commented 1 week ago

Seems like there's a separate system test that's failing, will investigate 🤔

adrianna-chang-shopify commented 1 week ago

Okay, turns out the failing iframe test was actually due to the same issue, because sprockets was calling URI::Generic::DEFAULT_PARSER.unescape.

This should be fixed now.