search

Shopify / maintenance_tasks

A Rails engine for queueing and managing data migrations.
MIT License
1.05k stars 76 forks source link

Add direct upload #1121

Open ehasrouni opened 1 week ago

ehasrouni commented 1 week ago

Adds the ability to enable direct uploads, which can help circumvent upload limits on the server. This is helpful when attempting to upload larger CSV files without having to play with the max size of 20mb

re-attempts https://github.com/Shopify/maintenance_tasks/pull/1031

etiennebarrie commented 1 week ago

There was a previous attempt at this: #1031
The main issue you're going to get is the lack of asset pipeline here: #1029

We should definitely support direct uploads, but I'd like to do it without requiring the asset pipeline. I think we might be able to rely on config.assets being present, and support both propshaft and sprockets. In the worst case we could support only propshaft. We could just use direct uploads when the asset pipeline is configured, but not otherwise. We probably don't need a configuration option for this.