search

Shopify / measured-rails

Rails adapter for the measured gem. Encapsulate measurements and their units in Ruby and Rails.
MIT License
92 stars 13 forks source link

Only depends on the dependencies we need #19

Closed rafaelfranca closed 8 years ago

rafaelfranca commented 8 years ago

We don't need the whole framework as dependency so we don't need to put the rails meta.

I also added test for the gem to make sure it works with Rails 5.

Review @kmcphillips.

There is a test failing but it is failing also in master. I can fix it if you point the expected behavior.

kmcphillips commented 8 years ago

Let me look at the failing test first. I'll stay on top of this. Thanks @rafaelfranca!

kmcphillips commented 8 years ago

Test is fixed on master so you can rebase it into this branch.

After that, one comment and the rest is :+1: :star:.

rafaelfranca commented 8 years ago

Done

rafaelfranca commented 8 years ago

Will you bump the version or should I use the git repository?

kmcphillips commented 8 years ago

I'll bump measured and measured-rails to 1.3.0 and bump the version in Shopify. Standby.