Improve tests around invalid units and saving

Shopify / measured-rails

Rails adapter for the measured gem. Encapsulate measurements and their units in Ruby and Rails.

MIT License

92 stars 13 forks source link

Improve tests around invalid units and saving #20

Closed kmcphillips closed 8 years ago

kmcphillips commented 8 years ago

@garethson @RichardBlair

I'm chasing a Measured::UnitError·Unit X does not exist error. I thought it might be in measured (it's not) but I was not confident in our test coverage around this.

No functional changes. Just test improvements.

garethson commented 8 years ago

Looks great. :ship:

kmcphillips commented 8 years ago

Added more tests with measured: true validation on. Still can't reproduce this error.

Pairing with @cyprusad

kmcphillips commented 8 years ago

Found it. Going to merge this then open a follow up with the behaviour change.