Shopify / measured-rails

Rails adapter for the measured gem. Encapsulate measurements and their units in Ruby and Rails.
MIT License
92 stars 13 forks source link

This addresses a bug where we use the wrong setter when assigning a Measured instance to a measured_field using a custom unit field #29

Closed benwah closed 7 years ago

benwah commented 7 years ago

I introduced a bug affecting measured fields using a custom unit accessor. This PR resolves the bug. Will bump to 1.6.1.

I wasn't using the correct accessor for <foo>_unit fields.

CR: @kmcphillips @jonathankwok

benwah commented 7 years ago

Nevermind - There is no bug, all there is, is human error.