search

Shopify / measured-rails

Rails adapter for the measured gem. Encapsulate measurements and their units in Ruby and Rails.
MIT License
92 stars 13 forks source link

Add Tapioca::Dsl::Compilers::MeasuredRails #71

Closed keiththomps closed 2 years ago

keiththomps commented 2 years ago

It is difficult to add typing information to sytems when models utilize measured_rails currently because there's no typing for the generated methods. This PR adds a tapioca compiler to do this. Historically, these seem to be put into tapioca itself, but this snippet frees us up to put these compilers directly into the gems that implement a DSL.

I had originally written this to go into tapioca itself, but had someone recommend that I add it here.

Currently CI is failing for ruby 2.6 which has reached its end of life. Relies on #72 to be mergable.

paracycle commented 2 years ago

Currently CI is failing for ruby 2.6 which has reached its end of life.

I think we should drop 2.6 support at this point. Anyone who needs to use the library can use the last release that supports 2.6.

keiththomps commented 2 years ago

@paracycle I've dropped ruby 2.6 support in this PR.