Shopify / measured-rails

Rails adapter for the measured gem. Encapsulate measurements and their units in Ruby and Rails.
MIT License
92 stars 13 forks source link

Centralize Ruby Version to `.ruby-version` #76

Closed alexcrocha closed 6 months ago

alexcrocha commented 7 months ago

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

[!IMPORTANT] Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

This PR will be merged if there isn't any activity after 4 weeks.

alexcrocha commented 7 months ago

CI is failing on rails-edge because it no longer supports Ruby 3.0 (source). With Ruby 3.0 reaching its EOL at the end of this month (source) I suggest we also drop our support for it.

kmcphillips commented 7 months ago

I'm good with removing it. We're going to do a release anyway, so may as well bump the minor version and just say it's 3.1.0+.

Will need to update the CI matrix: https://github.com/Shopify/measured-rails/blob/d9d4a7ecdb22b045d043f6df277478e34ee0c8ed/.github/workflows/ci.yml#L14

And all these changes mirrored to measured.

paracycle commented 6 months ago

CI is failing on rails-edge because it no longer supports Ruby 3.0 (source).

I already fixed this problem on main. Rebasing will fix it for you too.