search

Shopify / measured

Encapsulate measurements and their units in Ruby and Ruby on Rails.
MIT License
337 stars 28 forks source link

Fix Add new units README example #119

Closed AlexWheeler closed 5 years ago

AlexWheeler commented 5 years ago 
value: ["1.5 bu"]

To set a conversion rate you must pass either a string or a two-element array.

This updates the docs to use a string

value: "1.5 bu"

note how all the other units are using the string version https://github.com/Shopify/measured/tree/master/lib/measured/units

kmcphillips commented 5 years ago

Hey there! Thanks for the contribution.

I'm going to see if I can get CI to pass, because it clearly has nothing to do with you. If not I'll just merge it on red.

kmcphillips commented 5 years ago

I'm working on CI in #120 so I'm just going to merge this. Thanks!

AlexWheeler commented 5 years ago

awesome! thanks for the sweet gem

kmcphillips commented 5 years ago

Glad you find it useful!