search

Shopify / measured

Encapsulate measurements and their units in Ruby and Ruby on Rails.
MIT License
337 stars 28 forks source link

Add structure to unit errors #133

Closed arturopie closed 3 years ago

arturopie commented 3 years ago

This way, users of this library have more control on how to handle these errors, and provide their own custom error message.

arturopie commented 3 years ago

A few comments, but all of them small. I think this is a good change and a good approach!

Thanks for the quick review. PTAL

kmcphillips commented 3 years ago

Thank you for your contribution!

No promises on when we'll get a version cut, but you can use 15038ca9118e1922254484ce4dfa929d2d65c5a4 in your gemfile for the time being.

arturopie commented 3 years ago

Thank you for your contribution!

No promises on when we'll get a version cut, but you can use 15038ca9118e1922254484ce4dfa929d2d65c5a4 in your gemfile for the time being.

Thanks for accepting my PR and maintaining this project!

kmcphillips commented 3 years ago

This was released in 2.6.0