Closed alexcrocha closed 5 months ago
The same changes will need to be made here: https://github.com/Shopify/measured-rails/blob/main/dev.yml
We can release them together. (actually we must release them together)
The same changes will need to be made here: https://github.com/Shopify/measured-rails/blob/main/dev.yml
We can release them together. (actually we must release them together)
Thank you for the heads up 👍 It's on our list and I will add that note.
What are you trying to accomplish?
The
.ruby-version
file is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-version
file, ensures arequired_ruby_version
is set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-version
file is present with the correct Ruby version definedrequired_ruby_version
in your gemspec is setdev.yml
Ruby task (before:- ruby: x.x.x
, after:- ruby
)Gemfile
(no lines withruby <some-version>
)Gemfile.lock
is built with the defined Ruby versionTargetRubyVersion
defined inrubocop.yml
ruby/setup-ruby
Github Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”
)This PR will be merged if there isn't any activity after 4 weeks.