Shopify / measured

Encapsulate measurements and their units in Ruby and Ruby on Rails.
MIT License
337 stars 28 forks source link

Test with consistent Ruby/Rails versions #27

Closed kmcphillips closed 8 years ago

kmcphillips commented 8 years ago

@jonathankwok @benwah

Update our Travis builds so that it tests with mainline rails (5.0) by default, but also with 4.2. Matrix that with the same ruby versions used to test measured-rails. Skip 2.1.x for rails 5 because they are incompatible.

Aligns with https://github.com/Shopify/measured-rails/pull/24

benwah commented 8 years ago

@kmcphillips So from my understanding this results in testing these Rails / Ruby combinations now?

LGTM! 🚢

jonathankwok commented 8 years ago

👍

kmcphillips commented 8 years ago

Correct!

Travis takes the cross product of the ruby versions with the different gemfiles, and runs that matrix of tests.