Shopify / mobile-buy-sdk-android

Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using their credit card.
MIT License
211 stars 136 forks source link

Update OkHTTP dependency #762

Open mbreithu-wtd opened 2 months ago

mbreithu-wtd commented 2 months ago

The library depends on OkHTTP 3.7 (which is 4 years old). Most other libraries have upgraded to 4.x, which was the rewrite in Kotlin. Problems arise when using the buysdk and another package depending on okHTTP (>4.0) in the same application as Gradle will use the higher version in its conflict resolution strategy. This leads to a runtime crash, when the Buy SDK tries to call DiskLruCache.create in its DiskLruCacheStore class.

This static function does not exist in OkHttp > 4

mbreithu-wtd commented 2 months ago

It seems there has been an attempt at a workaround here: Pull-request

but the PR was closed without explanation

volodia-chornenkyy commented 2 months ago

Need updated OkHttp for our project as well.