Update to GraphQL API Version 2020-01

Shopify / mobile-buy-sdk-ios

Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using Apple Pay or their credit card.

MIT License

452 stars 199 forks source link

Update to GraphQL API Version 2020-01 #1046

Closed osamie closed 4 years ago

osamie commented 4 years ago

Summary of changes

Update to 2020-01 storefront API schema
Bump sdk version

Release notes (https://help.shopify.com/en/api/versioning/release-notes/2020-01#storefront-api-changes)

Retrieve a product’s media. Media supported: images, 3D models, and videos.
New supported currencies - SHP, GIP, and FKP
Get unit measurement and price data for product variants to display per-unit prices

This PR resolves https://github.com/Shopify/mobile-buy-sdk-ios/issues/1044

dbart01 commented 4 years ago

Looks good, my only ask is that we rebase this and squash all these reverts to keep a clean history.

dbart01 commented 4 years ago

Also, please PR this against develop, not master.

osamie commented 4 years ago

@dbart01 Thanks for the feedbacks!

Looks good, my only ask is that we rebase this and squash all these reverts to keep a clean history.

Done, squashed revert commits.

Also, please PR this against develop, not master.

Sure, I can do that. But I would like to know why we have this extra branch develop before master? Is it just a convention we blindly adopt in this repo or is it actually solving a problem?

osamie commented 4 years ago

Adding this note here: @jmignac before we do a release, please verify if there is anything else you want to see implemented for field translations in the sdk version 3.7.0. Merging this to develop branch.