Access Level Update for AbstractResponse.rawFields property

[mahmutpinarbasi]

Hi,

With latest 10.0.0 [2023-01] release, rawFields ( previously fields) property access level changed to internal on AbstractResponse class. which is kind a breaking change for entire serialize/deserialize operation on our app. So wondering was it intentional? Is it possible to switch back to public access level again?

You can also see the similar usage on mobile-buy-sdk-ios-sample

If you guys ok with it; I can create the PR. what do you think @cocoahero ?

[cocoahero]

Hi @mahmutpinarbasi - yes this was intentional as the previous property name was conflicting with a newly added schema field. We made it internal so that it would be easier to fix in the future if this were to happen again.

Curious how you are using this property? What serialization/deserialization are you having to do that the built in model objects do not provide?

[mahmutpinarbasi]

Hi @cocoahero,

My usage is as following;

extension GraphQL.AbstractResponse: Serializable {

    static func deserialize(from representation: SerializedRepresentation) -> Self? {
        return try? self.init(fields: representation)
    }

    func serialize() -> SerializedRepresentation {
        return self.fields
    }
}

We are using similar infrastructure on our app with buy sdk example app. You can get more details about the usage from here: https://github.com/Shopify/mobile-buy-sdk-ios-sample/blob/0565810b86227df0a0211d38490718e1f9f5eb7b/Storefront/GraphQL%2BSerializable.swift

[cocoahero]

Hi @mahmutpinarbasi - please see the above linked PR and let me know if that will solve for your use case.

[mahmutpinarbasi]

Hi @cocoahero,

It perfectly solves the issue. Thanks for the quick action.

[cocoahero]

The PR has been shipped and v10.1 has been tagged and released. I will work on updating the sample code to reflect the changes. Thanks for letting us know.