Shopify / mobile-buy-sdk-ios

Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using Apple Pay or their credit card.
MIT License
452 stars 198 forks source link

[BUG REPORT] - Invalid Apple-App-Site-Association #1233

Closed tsopin closed 6 months ago

tsopin commented 7 months ago

Please complete the checklist before filing an issue:

Expected Behavior

When enabling the iOS Buy SDK and App Clips in the Shopify Admin under "App Development" > "Configuration" > "Storefront Integration". The Apple-App-Site-Association file should be generated correctly with the key appclips, as required by Apple's guidelines. This should allow the website to pass Apple's validation and be published successfully.

Actual Behavior

However, the generated Apple-App-Site-Association file contains the incorrect key app_clips instead of appclips, leading to a failure in Apple's validation process. As a result, the app cannot be published.

Admin Screenshot

Screenshot 2024-04-17 at 2 19 37 PM

Results Screenshot

Screenshot 2024-04-17 at 2 23 28 PM
meta-merritt commented 7 months ago

@tsopin Curious, did you have any issues when bringing the SDK into your Xcode project? Right out of the box I'm getting a PaySession issue. Wish I could help with the above but not using app clips on my end.

Screenshot 2024-04-17 at 5 55 45 PM
tsopin commented 7 months ago

@meta-merritt I haven't even installed the SDK yet as I encountered this issue during the very first step of the setup process.

cocoahero commented 6 months ago

Hi @tsopin - Thanks for the report, this should now be fixed. Can you please verify?

tsopin commented 6 months ago

Thank you for the update. I can confirm that the issue has now been fixed ✅

JordanaFuller commented 6 months ago

Thank you team!!!