Nil Payment Returned From checkoutCompleteWithTokenizedPayment

[cocoahero]

When attempting to complete an Pay checkout, we are seeing payment objects being returned as nil from checkoutCompleteWithTokenizedPayment. The checkout then appears to be marked as abandoned and listed in our Abandoned Checkouts list in Shopify.

Here is the returned response from the mutation query:

(lldb) po response
<Mutation: ["checkoutCompleteWithTokenizedPayment": {
    checkout =     {
        completedAt = "<null>";
        email = "jonathan@jonathanbaker.me";
        id = "a-redacted-checkout-id";
        orderStatusUrl = "<null>";
    };
    payment = "<null>";
    userErrors =     (
    );
}]>

[cocoahero]

Should note that the sample app (Storefront) appears to have the same issue.

[davidmuzi]

The bug is in the sample app, there needs to be a call to mutationForUpdateCheckout:updatingShippingAddress to add a shipping address before completing the checkout

[cocoahero]

@davidmuzi wouldn't that have already been done via the paySession(_ paySession: PaySession, didUpdateShippingAddress: callback on the PaySessionDelegate?

https://github.com/Shopify/mobile-buy-sdk-ios/blob/master/Sample%20Apps/Storefront/Storefront/CartViewController.swift#L218

[davidmuzi]

Unfortunately, Apple only provides a partial address suitable only to fetch shipping rates on that call. Only once the user authorizes the payment does Apple provide the full shipping address in didAuthorizePayment

[calebd]

The API should return an error in that case. If it knows the checkout isn't really complete, why do we get a successful response?

[davidmuzi]

Agree 💯 %. We are going to fix that.

[calebd]

Thanks! We were beating our heads against this for a while haha.